{"id":1017,"date":"2010-02-08T14:03:25","date_gmt":"2010-02-08T19:03:25","guid":{"rendered":"http:\/\/mikeconley.ca\/blog\/?p=1017"},"modified":"2023-12-20T16:25:17","modified_gmt":"2023-12-20T21:25:17","slug":"pants-first-then-shoes-more-argument-for-pre-commit-code-review","status":"publish","type":"post","link":"https:\/\/mikeconley.ca\/blog\/2010\/02\/08\/pants-first-then-shoes-more-argument-for-pre-commit-code-review\/","title":{"rendered":"Pants First, Then Shoes:  More Argument for Pre-Commit Code Review"},"content":{"rendered":"<p>In my opinion, at least for <a href=\"http:\/\/www.markusproject.org\">The MarkUs Project<\/a>, post-commit code review would probably be analogous to putting on your shoes before your pants.\u00a0 And though <a href=\"http:\/\/mikeconley.ca\/blog\/2010\/02\/02\/pre-commit-code-review-in-markus-development\/\">I mentioned earlier<\/a> that there is <a href=\"http:\/\/stackoverflow.com\/questions\/246319\/peer-review-code-before-or-after-check-in\">plenty of preference for post-commit<\/a>, I forgot to include this juicy little tidbit.<\/p>\n<p><a href=\"http:\/\/david.navi.cx\/?p=149\">Click here to read one of the developers of ReviewBoard state his case for pre-commit code review.<\/a><\/p>\n<p>To each their own.\u00a0 But I dig his points.<\/p>\n","protected":false},"excerpt":{"rendered":"<p>In my opinion, at least for The MarkUs Project, post-commit code review would probably be analogous to putting on your shoes before your pants.\u00a0 And though I mentioned earlier that there is plenty of preference for post-commit, I forgot to include this juicy little tidbit. Click here to read one of the developers of ReviewBoard [&hellip;]<\/p>\n","protected":false},"author":4,"featured_media":0,"comment_status":"open","ping_status":"open","sticky":false,"template":"","format":"standard","meta":{"jetpack_post_was_ever_published":false,"_jetpack_newsletter_access":"","_jetpack_dont_email_post_to_subs":false,"_jetpack_newsletter_tier_id":0,"_jetpack_memberships_contains_paywalled_content":false,"_jetpack_memberships_contains_paid_content":false,"footnotes":"","jetpack_publicize_message":"","jetpack_publicize_feature_enabled":true,"jetpack_social_post_already_shared":false,"jetpack_social_options":{"image_generator_settings":{"template":"highway","default_image_id":0,"font":"","enabled":false},"version":2}},"categories":[454],"tags":[501,504],"class_list":["post-1017","post","type-post","status-publish","format-standard","hentry","category-code-reviews","tag-code-review","tag-reviewboard"],"jetpack_publicize_connections":[],"jetpack_featured_media_url":"","jetpack_shortlink":"https:\/\/wp.me\/prmTy-gp","jetpack_sharing_enabled":true,"_links":{"self":[{"href":"https:\/\/mikeconley.ca\/blog\/wp-json\/wp\/v2\/posts\/1017","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/mikeconley.ca\/blog\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/mikeconley.ca\/blog\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/mikeconley.ca\/blog\/wp-json\/wp\/v2\/users\/4"}],"replies":[{"embeddable":true,"href":"https:\/\/mikeconley.ca\/blog\/wp-json\/wp\/v2\/comments?post=1017"}],"version-history":[{"count":4,"href":"https:\/\/mikeconley.ca\/blog\/wp-json\/wp\/v2\/posts\/1017\/revisions"}],"predecessor-version":[{"id":3197,"href":"https:\/\/mikeconley.ca\/blog\/wp-json\/wp\/v2\/posts\/1017\/revisions\/3197"}],"wp:attachment":[{"href":"https:\/\/mikeconley.ca\/blog\/wp-json\/wp\/v2\/media?parent=1017"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/mikeconley.ca\/blog\/wp-json\/wp\/v2\/categories?post=1017"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/mikeconley.ca\/blog\/wp-json\/wp\/v2\/tags?post=1017"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}