{"id":2687,"date":"2015-03-27T10:03:12","date_gmt":"2015-03-27T15:03:12","guid":{"rendered":"http:\/\/mikeconley.ca\/blog\/?p=2687"},"modified":"2023-12-20T16:25:11","modified_gmt":"2023-12-20T21:25:11","slug":"the-joy-of-coding-episode-7-code-review-and-a-regression","status":"publish","type":"post","link":"https:\/\/mikeconley.ca\/blog\/2015\/03\/27\/the-joy-of-coding-episode-7-code-review-and-a-regression\/","title":{"rendered":"The Joy of Coding (Episode 7): Code review, and a Regression"},"content":{"rendered":"

In this episode, I started with some code review. I was reviewing a patch<\/a> to make the Findbar (particularly, the Find As You Type feature<\/a>) e10s-friendly.<\/p>\n

With that review out of the way, I had to swap a bunch of information about the plugin crash UI for e10s in my head – and in particular, some non-determinism that we have to handle. I explained that stuff (and hopefully didn’t spend too much time on it).<\/p>\n

Then, I showed how far I’d gotten with the plugin crash UI for e10s. I was able to submit a crash report, but I found I wasn’t able to type into the comment text area.<\/p>\n

After a while, I noticed that I couldn’t type into the comment text area on Nightly, even without my patch. And then I reproduced it in Aurora. And then in Beta. Luckily, I couldn’t reproduce it in Release – but with Beta transitioning to Release in only a few days, I didn’t have a lot of time to get a bug on file<\/a> to shine some light on it.<\/p>\n

Luckily, our brilliant Steven Michaud was on the case, and has just landed a patch to fix this. Talk about fast work!<\/p>\n

Episode Agenda<\/a><\/p>\n

References:
\n Bug 1133981 – [e10s] Stop sending unsafe CPOWs after the findbar has been closed in a remote browser<\/a><\/p>\n

Bug 1110887 – With e10s, plugin crash submit UI is broken<\/a> – Notes<\/a><\/p>\n

Bug 1147521 – Cannot type into comment area of plugin crash UI<\/a><\/p>\n