{"id":2727,"date":"2015-04-25T16:22:21","date_gmt":"2015-04-25T21:22:21","guid":{"rendered":"http:\/\/mikeconley.ca\/blog\/?p=2727"},"modified":"2023-12-20T16:25:11","modified_gmt":"2023-12-20T21:25:11","slug":"the-joy-of-coding-ep-11-cleaning-up-the-view-source-patch","status":"publish","type":"post","link":"https:\/\/mikeconley.ca\/blog\/2015\/04\/25\/the-joy-of-coding-ep-11-cleaning-up-the-view-source-patch\/","title":{"rendered":"The Joy of Coding (Ep. 11): Cleaning up the View Source Patch"},"content":{"rendered":"

For this episode, Richard Milewski<\/a> and I figured out the syncing issue I’d been having in Episode 9<\/a>, so I had my head floating in the bottom right corner while I hacked. Now you can see what I do with my face while hacking, if that’s a thing you had been interested in.<\/p>\n

I’ve also started mirroring the episodes to YouTube<\/a>, if YouTube is your choice platform for video consumption.<\/p>\n

So, like last week, I was under a bit of time pressure because of a meeting scheduled for 2:30PM (actually the meeting I was supposed to have the week before – it just got postponed), so that gave me 1.5 hours to move forward with the View Source work we’d started back in Episode 8<\/a>.<\/p>\n

I started the episode by explaining that the cache key stuff we’d figured out in Episode 9<\/a> was really important, and that a bug had been filed<\/a> by the Necko team to get the issue fixed. At the time of the video, there was a patch up for review in that bug, and when we applied it, we were able to retrieve source code out of the network cache after POST requests! Success!<\/p>\n

Now that we had verified that our technique was going to work, I spent the rest of the episode cleaning up the patches we’d written. I started by doing a brief self-code-review to smoke out any glaring problems, and then started to fix those problems.<\/p>\n

We got a good chunk of the way before I had to cut off the camera.<\/p>\n

I know back when I started working on this particular bug, I had said that I wanted to take you through right to the end on camera – but the truth of the matter is, the priority of the bug went up, and I was moving too slowly on it, since I was restricting myself to a few hours on Wednesdays. So unfortunately, after my meeting, I went back to hacking on the bug off-camera, and yesterday I put up a patch for review. Here’s the review request, if you’re interested in seeing where I got to!<\/a><\/p>\n

I felt good about the continuity experiment, and I think I’ll try it again for the next few episodes – but I think I’ll choose a lower-priority bug; that way, I think it’s more likely that I can keep the work contained within the episodes.<\/p>\n

How did you feel about the continuity between episodes? Did it help to engage you, or did it not matter? I’d love to hear your comments!<\/p>\n

Episode Agenda<\/a><\/p>\n

References<\/h2>\n

Bug 1025146 – [e10s] Never load the source off of the network when viewing source<\/a> – Notes<\/a><\/p>\n