If you didn’t already know, Review Board is an open-source web-based code review tool. The MarkUs Team has been using Review Board for pre-commit code review for about a year now. This has given the team a number of advantages:
- For a team that usually has a 4 month turnover, this allows us to quickly get new team members up to speed with how to contribute to MarkUs. We review every change that they propose, and give them tips/guidance on how to make it fit in well with the application. They learn, and the applications code stays healthy.
- We catch defects before they enter the code base. Simple as that.
- We get a good sense of what other people are working on, and what is going on in the code. Review Board has become a central conversation and learning hub for the developers on the MarkUs team.
So, the long and the short of it: I like Review Board. Review Board helps us write better code. I want to make Review Board better.
So what am I proposing?
How to Avoid A Bloated Software Monster
You can never make some people happy.
No matter how decent your software is, someone will eventually come up to you and say:
Wow! Your software would be perfect if only it had feature XYZ! Sadly, because you don’t have feature XYZ, I can’t use it. Please implement, k thx!
And so you either have to politely say “no”, and lose that user, or say “yes”, and add feature XYZ to the application. And for users out there who don’t need, or don’t care about feature XYZ, that new feature just becomes a distraction and adds no value. Make this happen a bunch of times, and you’ve got yourself a bloated mutha for a piece of software.
And we don’t want a bloated piece of software. But we do want to make our users happy, and provide feature XYZ for them if they want it.
So what’s the solution? We provide an extension framework (which is also sometimes called a plug-in architecture).
An extension framework allows developers to easily expand a piece of software to do new things. So, if a user wants feature XYZ, we (or someone else) just creates and make available an extension that implements the feature. The user installs the extension, activates it, and bam – our user is happy as a clam with their new feature.
And if we make it super-easy to develop them, third-party developers can write new, wonderful, interesting extensions to do things that…well, we wouldn’t have considered in the first place. It’s a new place for innovation. What’s that old cliché?
If you build it [the plug-in framework], they will come [the third-party developers who write awesome things]
And the developers do come. Just look at Firefox add-ons or WordPress plugins. Entire ecosystems of extensions, doing things that the original developers would probably have never dreamed of doing on their own. Hell, I’ve even written a Firefox add-on. And users love customizing their Firefox / WordPress with those extensions. It adds value.
So we get wins all over the place:
- Our user gets their feature
- The software gets more attractive because it’s flexible and customizable
- The original software developers get to focus on the core piece of software, and let the third-party developers focus on the fringe features
And this is where I think I can help Review Board.
(Before I go on, if you’re interested, here’s another article on the how and the why of plug-in architectures)
Review Board Extensions
It would be nice if the review board had a “next comment” button that is always available to click, or had a collapse/expand button. This would make it easier to see other people’s comments in cases like this.
It will be nice to have post-commit support. Instead of every post-commit review being a separate URL, if we could setup default rules for post-commit reviews to update an existing review providing the diff-between-diff features, it would be very useful.
The Review Board developers could smell the threat of bloated feature-creep from a mile away. So, in a separate branch, they began working on integrating an extension framework into Review Board.
The extension branch, however, has been gathering dust, while the developers focus on more critical patches and releases.
My GSoC proposal is to finish off a draft of the extension framework, document it, and build a very simple extension for it. My simple extension will allow me to record basic statistics about Review Board reviewers – for example, how long they spend on a particular review, their inspection rate, etc.
Having been a project lead MarkUs for so long, it’s going to be a good experience to be back on “the bottom” – to be the new developer who doesn’t entirely have a sense of the application code yet. It’s going to be good to go code spelunking again. I’ve done some preliminary explorations, and it’s reminding me of my first experiences with MarkUs. Like a submarine using its sonar, I’m slowly getting a sense of the code terrain.
I’ll let you know what my first few sweeps find.